[Webtest] Patch for bug in com.canoo.webtest.reporting.XmlResultConverter

Dierk Koenig webtest@lists.canoo.com
Fri, 8 Aug 2003 19:42:17 +0200


Hi Marc

thanx for the post.

I totally agree to your point and introduce the change.

It is fairly obvious that the tests for result converting do not go much
into implementation details. Most people argue that this makes no sense
testing. But here the test would have helped.

ciao and thanx
Mittie

> -----Original Message-----
> From: webtest-admin@lists.canoo.com
> [mailto:webtest-admin@lists.canoo.com]On Behalf Of Marc Guillemot
> Sent: Donnerstag, 7. August 2003 18:45
> To: WebTest@lists.canoo.com
> Subject: [Webtest] Patch for bug in
> com.canoo.webtest.reporting.XmlResultConverter
>
>
> Hi,
>
> in com.canoo.webtest.reporting.XmlResultConverter.addParameters (line 166
> for build 362)
> instead of:
>     String value = parameter.getValue() != null ? (String)
> parameter.getValue() : "null";
> use:
>     String value = String.valueOf(parameter.getValue());
>
> a parameter can be something else as a String (for instance a
> Boolean, which
> produces an hard to catch bug as no stack trace get printed from
> com.canoo.webtest.ant.TestSpecificationTask.report()). Furthermore is the
> code cleaner.
>
> Marc.
>
> _______________________________________________
> WebTest mailing list
> WebTest@lists.canoo.com
> http://lists.canoo.com/mailman/listinfo/webtest
>