[Webtest] thoughts required on name for step to be added to main distribution

Denis N. Antonioli webtest@lists.canoo.com
Thu, 23 Dec 2004 14:38:26 +0100 (CET)


Hi Paul

These steps adds usefull capabilities, thank you!

There is one semantic point that I don't understand though:
why are all these variations of parameters necessary?
Isn't it sufficient to have the single choice:
<storeAntProperty property="antProp" value="some value" />

This already lets store the value of a dynamic property with:
<storeAntProperty property="antProp" value="#{dynProp}" />
or an ant property with:
<storeAntProperty property="antProp" value="${antProp_new}" />

I would also rather have an attribute 'property' rather than 'antname'
in order to stay close to ant's ususal namings.

Best
	dna

On Thu, 23 Dec 2004, Paul King wrote:

> 
> I was going to add the exportProperty step to the main distribution. I 
> would like to know if anyone has a preference on what name to call it 
> (perhaps we can use the +1, -1, 0 "voting" style of other open source 
> communities to gauge interest).
> 
> Option 0:
> 
> Leave storeDynamicProperty as is and exportProperty as is.
> 
> Option 1:
> 
> Call it storeAntProperty to match existing storeDynamicProperty. I would 
> propose two forms:
> 
> <storeAntProperty antname="antProp" name="dynProp" />
> <storeAntProperty antname="antProp" value="some value" />
> 
> The first of these is likely to be rarely used but allows the dynamic 
> property name to be fed in via an expression.
> 
> I would also augment storeDynamicProperty to have
> 
> <storeDynamicProperty name="dynProp" antname="antProp" />
> 
> Which supports late binding to ant properties.
> 
> Option 2:
> 
> Rename storeDynamicProperty to importProperty and leave exportProperty 
> name unchanged. (We can leave a storeDynamicProperty entry in 
> webtestTaskdefs.properties file for backwards compatibility)
> 
> Option 3:
> 
> Rename storeDynamicProperty to storeProperty and support three forms:
> 
> <storeProperty name="dynPropName" value="some value" />
> <storeProperty antname="antPropName" value="some value" />
> <storeProperty name="dynPropName" antname="antPropName" />
> 
> The final form supports the late binding transfer of an ant property to 
> a dynmamic property. (Again, we can leave a storeDynamicProperty entry 
> in webtestTaskdefs.properties file for backwards compatibility)
> 
> At the moment I am leaning towards option 3 but it doesn't allow for the 
> case of wanting to transfer a dynamic property to an ant property using 
> an expression for the name of the ant property. Also, it isn't quite 
> symmetrical.
> 
> What do others think?
> 
> Thanks, Paul.
> 
> _______________________________________________
> WebTest mailing list
> WebTest@lists.canoo.com
> http://lists.canoo.com/mailman/listinfo/webtest
>