[Webtest] [webtest][JIRA] Created: (WT-27) Run-time dependency on JUnit

[Etienne Studer]

Hi Denis

I vote strongly for 1). If you go for 2), you will have to rewrite more 
or less the whole testing aspect of pdftest and its integration into 
webtest (the only thing that wouldn't change is the "business logic" of 
retrieving the pdf properties/values thorugh the PdfboxPdfAnalyzer). My 
idea was to let JUnit do the testing (value comparison, failure 
procedure, consistent messages, etc.). Webtest is just a wrapper around 
this pdfUnit.

But If you think 2) is the better way, that's fine with me, too. It just 
means a lot more work when including junit.jar into lib/runtime solves 
the problem. But easier does not always mean cleaner or better, of 
course ;-)

Have a nice week-end!

--Etienne


Denis N. Antonioli (JIRA) wrote:
> Run-time dependency on JUnit
> ----------------------------
> 
>          Key: WT-27
>          URL: http://webtest-community.canoo.com/jira/browse/WT-27
>      Project: WebTest
>         Type: Task
>     Reporter: Denis N. Antonioli
> 
> 
> The step VerifyPdfTextFieldStep introduces a run-time dependency on junit.
> 
> com.canoo.webtest.steps.pdftest.VerifyPdfTextFieldStep uses a
>    com.canoo.pdftest.testcase.PdfTextFieldExistsTestCase
> that extends
>    junit.framework.TestCase
> 
> PdfTextFieldExistsTestCase itself is not part of webtest but is in lib/pdfUnit.
> 
> 
> We have the choice of
> (1) keep the dependecy and move junit from lib/build to lib/runtime
> or 
> (2) remove the dependeny and change the pdf pacakge,.
> 
>