[Webtest] [dev] refactoring

Dierk Koenig webtest@lists.canoo.com
Thu, 4 Aug 2005 16:26:07 +0200


> - WebTestSpec contains the map of dynamic properties. According 
> to your explaination, it should be in Context

Yes, it should move over there.
(make the old method deprecated with relay to the new impl)

> - Context contains getNumberOfSteps() which is just a shortcut to 
> get an info of the WebTestSpec

just a convenience method but may probably better be moved to
WebTestSpec.

> if the distinction between Context and WebTestSpec isn't logical 
> (and that's currently the case) the design would be 
> cleaner after a collapse. 

To me the current separation is logical, even though the usage
can be improved (see above).
Collapsing would make WebTestSpec less coherent.

> In fact I think that we should rather use execute() as start 
> point for the execution of a step to handle in the future 
> normal ant tasks as well as webtest steps in the same way within 
> a <webtest>.

in addition to usual tasks, steps need to do some common work
around doExecute(), see Step.execute().

ciao
Mittie